[Github][libcxx] Run Container Build Workflow on Stacked PRs #150683
Conversation
Currently the container build workflow does not run on stacked PRs that do not have a branch target of main because of how the workflow is configured. This makes the workflow better confirm to the LLVM CI best practices around Github workflows: https://llvm.org/docs/CIBestPractices.html#ensuring-workflows-run-on-the-correct-events
boomanaiden154
requested review from
tstellar,
ldionne,
DavidSpickett,
EricWF and
cmtice
llvmbot
added
libc++
|
@llvm/pr-subscribers-libcxx Author: Aiden Grossman (boomanaiden154) ChangesCurrently the container build workflow does not run on stacked PRs that do not have a branch target of main because of how the workflow is configured. This makes the workflow better confirm to the LLVM CI best practices around Github workflows: https://llvm.org/docs/CIBestPractices.html#ensuring-workflows-run-on-the-correct-events Full diff: https://github.com/llvm/llvm-project/pull/150683.diff 1 Files Affected:
diff --git a/.github/workflows/libcxx-build-containers.yml b/.github/workflows/libcxx-build-containers.yml
index 564a79341edb1..f432e3ddd5d1e 100644
--- a/.github/workflows/libcxx-build-containers.yml
+++ b/.github/workflows/libcxx-build-containers.yml
@@ -18,8 +18,6 @@ on:
- 'libcxx/utils/ci/**'
- '.github/workflows/libcxx-build-containers.yml'
pull_request:
- branches:
- - main
paths:
- 'libcxx/utils/ci/**'
- '.github/workflows/libcxx-build-containers.yml'
|
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesCurrently the container build workflow does not run on stacked PRs that do not have a branch target of main because of how the workflow is configured. This makes the workflow better confirm to the LLVM CI best practices around Github workflows: https://llvm.org/docs/CIBestPractices.html#ensuring-workflows-run-on-the-correct-events Full diff: https://github.com/llvm/llvm-project/pull/150683.diff 1 Files Affected:
diff --git a/.github/workflows/libcxx-build-containers.yml b/.github/workflows/libcxx-build-containers.yml
index 564a79341edb1..f432e3ddd5d1e 100644
--- a/.github/workflows/libcxx-build-containers.yml
+++ b/.github/workflows/libcxx-build-containers.yml
@@ -18,8 +18,6 @@ on:
- 'libcxx/utils/ci/**'
- '.github/workflows/libcxx-build-containers.yml'
pull_request:
- branches:
- - main
paths:
- 'libcxx/utils/ci/**'
- '.github/workflows/libcxx-build-containers.yml'
|
|
(Merging despite the libc++ docker image workflow failing as it is broken for unrelated reasons). |
…0683) Currently the container build workflow does not run on stacked PRs that do not have a branch target of main because of how the workflow is configured. This makes the workflow better confirm to the LLVM CI best practices around Github workflows: https://llvm.org/docs/CIBestPractices.html#ensuring-workflows-run-on-the-correct-events
Currently the container build workflow does not run on stacked PRs that do not have a branch target of main because of how the workflow is configured. This makes the workflow better confirm to the LLVM CI best practices around Github workflows:
https://llvm.org/docs/CIBestPractices.html#ensuring-workflows-run-on-the-correct-events